Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: color definition fixes #140

Merged
merged 10 commits into from
Nov 23, 2024
Merged

fix: color definition fixes #140

merged 10 commits into from
Nov 23, 2024

Conversation

a2937
Copy link
Member

@a2937 a2937 commented Nov 23, 2024

Checklist:

Closes #XXXXX

For some reason --danger isn't working but this should fix a few of my mistakes.

@a2937 a2937 requested a review from a team as a code owner November 23, 2024 02:38
@a2937 a2937 force-pushed the fix/color-definition-fixes branch from 9213ce5 to 431c26d Compare November 23, 2024 02:42
ShaunSHamilton
ShaunSHamilton approved these changes Nov 23, 2024
View reviewed changes
Copy link
Member

@ShaunSHamilton ShaunSHamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
This LGTM

@ShaunSHamilton
Copy link
Member

This also appears to fix the issue with --tertiary not resolving to a hex.

@ShaunSHamilton ShaunSHamilton merged commit a627373 into freeCodeCamp:main Nov 23, 2024
1 check passed
@ShaunSHamilton ShaunSHamilton mentioned this pull request Nov 23, 2024
Closed
@a2937 a2937 deleted the fix/color-definition-fixes branch November 23, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaunSHamilton ShaunSHamilton ShaunSHamilton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a2937 @ShaunSHamilton